Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Complete parallel Coveralls uploads #5759

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

psafont
Copy link
Member

@psafont psafont commented Jul 1, 2024

When uploading more than one coverage result to coveralls, it needs to be told when all of them are done

Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
@coveralls
Copy link

Coverage Status

coverage: 44.887%. first build
when pulling f40a624 on psafont:endcover
into 6969a8a on xapi-project:master.

@edwintorok edwintorok merged commit 2008661 into xapi-project:master Jul 1, 2024
15 checks passed
@edwintorok
Copy link
Contributor

The DCO complains when I try to use this on another branch:

commit 1262d198d75c6dadbca5d0c5c4cd2db93d6d0a6f (HEAD -> feature/perf, edwintorok/feature/perf)
Author: Bernhard Kaindl <bernhard.kaindl@cloud.com>
Date:   Thu Jun 27 12:00:00 2024 +0200

    CI: Complete parallel Coveralls uploads: Finish when done

    Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>

Commit sha: 1262d19, Author: Bernhard Kaindl, Committer: Edwin Török; Expected "Bernhard Kaindl bernhard.kaindl@cloud.com", but got "Pau Ruiz Safont pau.ruizsafont@cloud.com".

I don't know why it didn't complain on the original PR

@psafont psafont deleted the endcover branch July 1, 2024 15:42
@psafont
Copy link
Member Author

psafont commented Jul 1, 2024

Maybe because it was cherry-picked and so you appear as the committer.

@edwintorok
Copy link
Contributor

Maybe because if I cherry-pick then I become the commiter, so now the author is nowhere in the git object anymore

@edwintorok
Copy link
Contributor

There are some race conditions in the CI run apparently, it complains about a missing build: #5761 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants