CA-395174: Try to unarchive VM's metrics when they aren't running #5855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwintorok
reviewed
Jul 19, 2024
edwintorok
reviewed
Jul 19, 2024
edwintorok
approved these changes
Jul 19, 2024
Non-running VMs' metrics are stored in the coordinator. When the coordinator is asked about the metrics try to unarchive them instead of failing while trying to fetch the coordinator's IP address. This needs to force the HTTP method of the query to be POST Also returns a Service Unavailable when the host is marked as Broken. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Forces users to use an address, instead of being implicit, this avoid the underlying cause for the issue fixed in the previous commit: it allowed a coordinator to call Pool_role.get_master_address, which always fails. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
This makes the selection of the action obvious, previously the two booleans made it hazy to understand the decision, and was part of the error why the coordinator tried to get the coordinator address from the pool_role file (and failed badly) Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
Currently a List.assoc is used, which raises an unhandled exception. Signed-off-by: Pau Ruiz Safont <pau.ruizsafont@cloud.com>
lindig
approved these changes
Jul 22, 2024
Vincent-lau
approved these changes
Jul 22, 2024
ocaml/xapi/rrdd_proxy.ml
Outdated
| unarchive () | ||
| else | ||
| | Slave _, true, _ | Slave _, _, false -> |
There was a problem hiding this comment.
If the current host is a slave, and the owner is a the local host (which is the Slave _, true, _ case), why do we need to ask the coordinator here? Although it seems that line 69 already checks that the metrics is not available locally
There was a problem hiding this comment.
When a host reboot and starts running a VM again, it needs to fetch the VM's metrics, leading to this convoluted flow:
member ----get_metrics---> coordinator ----get_metrics---> member ---unarchive---> coordinator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-running VMs' metrics are stored in the coordinator. When the coordinator is
asked about the metrics try to unarchive them instead of failing while trying
to fetch the coordinator's IP address.
This needs to force the HTTP method of the query to be POST
Also returns a Service Unavailable when the host is marked as Broken.
A build with these changes has passed the automated tests that discovered the issue: Job 4055228