Be careful comparing CMake strings to empty, in Findsodium #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Findsodium uses the following to see if the user has specified the name of the sodium libraries (I don't know why it allows that, but it does):
if (sodium_LIBRARIES STREQUAL "")
If this is true, then it sets it to the reasonable default
sodium
.The problem is that if
sodium_LIBRARIES
is not even set, then this is untrue, sosodium_LIBRARIES
never gets set, and we callfind_library
on an unset variable (and thus never find that library).This fixes that by explicitly augmenting that check to
if (NOT DEFINED sodium_LIBRARIES OR sodium_LIBRARIES STREQUAL "")