Control EP updates #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 6, 2019 13:47
…ange command types to DATA and COMMAND, with COMMAND packets being sent over USB Control endpoints..
|
Fixes #12 |
added 5 commits
September 12, 2019 17:43
|
Fixes #13 |
|
Fixes #16 |
|
Fixes #10 |
drbild
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
Nice!! This looks good enough to me to merge.
I'll write some comments on a hard-copy later this week, but they should be addressed as new issues, not as more working building up on this PR. They aren't major issues (word-smithing on writing, typo s, requests for more detail in certain areas, etc.), so we shouldn't hold up further progress waiting on them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19