This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
Allow assigning Coercible values + NamedNode internal class #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
TomNicholas
added a commit
to TomNicholas/datatree
that referenced
this pull request
Jun 17, 2022
TomNicholas
added a commit
that referenced
this pull request
Jun 26, 2022
* sketching out changes needed to integrate variables into DataTree * fixed some other basic conflicts * fix mypy errors * can create basic datatree node objects again * child-variable name collisions dectected correctly * in-progres * add _replace method * updated tests to assert identical instead of check .ds is expected_ds * refactor .ds setter to use _replace * refactor init to use _replace * refactor test tree to avoid init * attempt at copy methods * rewrote implementation of .copy method * xfailing test for deepcopying * pseudocode implementation of DatasetView * Revert "pseudocode implementation of DatasetView" This reverts commit 52ef23b. * removed duplicated implementation of copy * reorganise API docs * expose data_vars, coords etc. properties * try except with calculate_dimensions private import * add keys/values/items methods * don't use has_data when .variables would do * explanation of basic properties * add data structures page to index * revert adding documentation in favour of that going in a different PR * explanation of basic properties * add data structures page to index * create tree node-by-node * create tree from dict * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * dict-like interface * correct deepcopy tests * use .data_vars in copy tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * black * whatsnew * data contents * dictionary-like access * TODOs * test assigning int * allow assigning coercible values * simplify example using #115 * add note about fully qualified names Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
flamingbear
pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
…ntrib/datatree#115 * test assigning int * allow assigning coercible values * refactor name-related methods to intermediate class * refactor tests to match * fix now-exposed bug with naming * moved test showing lack of name permanence * whatsnew
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112 (which was trivial), but then also fixes a bug I noticed with name permanence. This bug wasn't exposed because the name-related tests were testing
TreeNodeinstead ofDataTree, so I refactored until the existing tests correctly exposed the bug. Then I fixed the bug.pre-commit run --all-filesdocs/source/whats-new.rst