This repository has been archived by the owner on Oct 24, 2024. It is now read-only.
[WIP] Add typed ops #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 25, 2021
|
After #32 this now works easily! I've also refactored so that the long lists of methods to copy all live in their own |
flamingbear
pushed a commit
to flamingbear/rewritten-datatree
that referenced
this pull request
Jan 19, 2024
* added methods from xarray.core._typed_ops.py to list to map over * test ops with non-datatrees acting on datatrees * removed the xfails * refactored ops out into new file * linting * minimise imports of xarray internals
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the operations defined in
xarray.core._typed_ops.py, such as__add__and__mul__.There is one test (for multiplication), but for reasons I don't understand it works when doing
dt * 5but fails fordt * dt.