-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support quantile, median, mode with method="blockwise". #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow method="blockwise" when grouping by a dask array. This can only work if we have expected_groups, and set reindex=True.
dcherian
commented
Oct 4, 2023
dcherian
changed the title
Support quantile, median with method="blockwise".
Support quantile, median, mode with method="blockwise".
Oct 5, 2023
This reverts commit d46c3ae.
dcherian
added a commit
to mathause/flox
that referenced
this pull request
Oct 7, 2023
* upstream/main: Support quantile, median, mode with method="blockwise". (xarray-contrib#269) Add multidimensional binning demo (xarray-contrib#203) [pre-commit.ci] pre-commit autoupdate (xarray-contrib#268) Drop python 3.8, test python 3.11 (xarray-contrib#209) tests: move xfail out of functions (xarray-contrib#265) Bump actions/checkout from 3 to 4 (xarray-contrib#267)
dcherian
added a commit
that referenced
this pull request
Nov 3, 2023
* main: (24 commits) Add `packaging` as dependency use engine flox for ordered groups (#266) Update pyproject.toml: py3.12 Bump numpy to >=1.22 (#278) Cleanups (#276) benchmarks updates (#273) repo-review comments (#270) Significantly faster cohorts detection. (#272) Add engine="numbagg" (#72) Support quantile, median, mode with method="blockwise". (#269) Add multidimensional binning demo (#203) [pre-commit.ci] pre-commit autoupdate (#268) Drop python 3.8, test python 3.11 (#209) tests: move xfail out of functions (#265) Bump actions/checkout from 3 to 4 (#267) convert datetime: micro-optimizations (#261) compatibility with `numpy>=2.0` (#257) replace the deprecated `provision-with-micromamba` with `setup-micromamba` (#258) Fix some typing errors in asv_bench and tests (#253) [pre-commit.ci] pre-commit autoupdate (#250) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mode
We allow method="blockwise" when grouping by a dask array. This can only work if we have expected_groups, and set reindex=True.