-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subtitles should support being read with encoding #57
Comments
Ok, what I need has landed as bb1d93f1604f08bc26f74f9cb569e463f120a56b in https://github.com/Ivshti/srt2vtt/commits/master .. @xat Would you kindly merge this and push a shiny release :) |
@kim0 That commit at first neededs to get merged into the official srt2vtt project ( which is not a project of mine ) over here https://github.com/deestan/srt2vtt and then get published on npm. @Ivshti Would you mind making an Pull Request out of this to the offical project? There is also another srt-to-vtt module by mafintosh https://github.com/mafintosh/srt-to-vtt which got published recently. I'll have a closer look at that one too. |
@kim0 Can you give me an download link to your arabic subtitles? That would make testing easier. |
@kim0 Sorry for spamming you :-D |
phew /me unlucky then :) It might not magically auto-detect it, but I don't mind passing --enc cp1256 .. is that possible |
FYI, for testing you could download a sample arabic subtitles from http://subscene.com/subtitles/fury/arabic/1045421 |
Thanks for the link. I'll implement this in v0.5 |
Thanks! |
Hi @xat. I have French subtitles. Accents like é, ', à... are not supported. What could we do to solve that? Thanks in advance, |
turkish characters also shown wrong I guess the encoding of the text should be picked automatically. and is there a way to resize subtitles |
My subtitles are written in Arabic (Windows-1256) code-pages. Kindly allow a setting to specify the code-page to read the text file with.
As a second more advanced phase, it would be awesome to heuristically guess the file code-page and apply it by default
The text was updated successfully, but these errors were encountered: