Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtitles should support being read with encoding #57

Open
kim0 opened this issue Jan 13, 2015 · 10 comments
Open

subtitles should support being read with encoding #57

kim0 opened this issue Jan 13, 2015 · 10 comments
Milestone

Comments

@kim0
Copy link

kim0 commented Jan 13, 2015

My subtitles are written in Arabic (Windows-1256) code-pages. Kindly allow a setting to specify the code-page to read the text file with.

As a second more advanced phase, it would be awesome to heuristically guess the file code-page and apply it by default

@kim0
Copy link
Author

kim0 commented Jan 15, 2015

Ok, what I need has landed as bb1d93f1604f08bc26f74f9cb569e463f120a56b in https://github.com/Ivshti/srt2vtt/commits/master .. @xat Would you kindly merge this and push a shiny release :)

@xat
Copy link
Owner

xat commented Jan 15, 2015

@kim0 That commit at first neededs to get merged into the official srt2vtt project ( which is not a project of mine ) over here https://github.com/deestan/srt2vtt and then get published on npm.

@Ivshti Would you mind making an Pull Request out of this to the offical project?

There is also another srt-to-vtt module by mafintosh https://github.com/mafintosh/srt-to-vtt which got published recently. I'll have a closer look at that one too.

@xat
Copy link
Owner

xat commented Jan 15, 2015

@kim0 Can you give me an download link to your arabic subtitles? That would make testing easier.

@xat
Copy link
Owner

xat commented Jan 15, 2015

@kim0 Sorry for spamming you :-D
Just noticed that Arabic does not seem to be supported by the charset detection lib used in that commit.
https://github.com/aadsm/jschardet

@kim0
Copy link
Author

kim0 commented Jan 15, 2015

phew /me unlucky then :) It might not magically auto-detect it, but I don't mind passing --enc cp1256 .. is that possible

@kim0
Copy link
Author

kim0 commented Jan 15, 2015

FYI, for testing you could download a sample arabic subtitles from http://subscene.com/subtitles/fury/arabic/1045421

@xat xat added this to the v0.5 milestone Jan 16, 2015
@xat
Copy link
Owner

xat commented Jan 16, 2015

Thanks for the link. I'll implement this in v0.5

@kim0
Copy link
Author

kim0 commented Jan 16, 2015

Thanks!

@HLFH
Copy link

HLFH commented Apr 1, 2015

Hi @xat. I have French subtitles. Accents like é, ', à... are not supported. What could we do to solve that? Thanks in advance,

@berkaytheunicorn
Copy link

turkish characters also shown wrong I guess the encoding of the text should be picked automatically. and is there a way to resize subtitles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants