Add a way to set postgres role when executing migrations #226
Conversation
In same cases we want to set a specific role when executing migrations, so the ownerhsip of the created/updated objects is different from the pgroll user (storing pgroll state). This change allows to set a role that will be set in the connection executing migrations.
|
I added some tests, let me know what you think! |
pkg/testutils/util.go
Outdated
| @@ -113,7 +113,7 @@ func WithStateAndConnectionToContainer(t *testing.T, fn func(*state.State, *sql. | |||
| fn(st, db) | |||
| } | |||
|
|
|||
| func WithMigratorInSchemaWithLockTimeoutAndConnectionToContainer(t *testing.T, schema string, lockTimeoutMs int, fn func(mig *roll.Roll, db *sql.DB)) { | |||
| func WithMigratorInSchemaConnectionToContainerWithOptions(t *testing.T, schema string, opts []roll.Option, fn func(mig *roll.Roll, db *sql.DB)) { | |||
There was a problem hiding this comment.
To follow the pattern of the other With* helper functions this could be called:
WithMigratorInSchemaAndConnectionToContainerWithOptions
pkg/testutils/util.go
Outdated
| os.Exit(1) | ||
| } | ||
|
|
||
| // create handy role for tets |
| @@ -153,7 +175,7 @@ func WithMigratorInSchemaWithLockTimeoutAndConnectionToContainer(t *testing.T, s | |||
| t.Fatal(err) | |||
| } | |||
|
|
|||
| mig, err := roll.New(ctx, connStr, schema, lockTimeoutMs, st) | |||
| mig, err := roll.New(ctx, connStr, schema, st, opts...) | |||
There was a problem hiding this comment.
Rather than create a role called pgroll in SharedTestMain would it better to create a role with the role name specified in opts here?
The way it works now is that the only role option name that will actually work is pgroll.
There was a problem hiding this comment.
these opts are part of the roll package, should I make Options public for this? happy to do the change but a bit on the fence on the benefit and resulting interfaces
There was a problem hiding this comment.
I'm happy to leave the hard-coded role creation of thepgroll role as-is in this case then 👍
pkg/testutils/util.go
Outdated
| os.Exit(1) | ||
| } | ||
|
|
||
| // create handy role for tets |
There was a problem hiding this comment.
As mentioned in another comment it might be better not to create a role here but do it in the test helper function instead.
In same cases we want to set a specific role when executing migrations, so the ownerhsip of the created/updated objects is different from the pgroll user (storing pgroll state). This change allows to set a role that will be set in the connection executing migrations.