Allow to disable version schemas #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are situatiosn were creating schema verisons is not required. This internal flag will allow to disable creating & managing these schemas when needed. Note: I opted to not expose this flag to the CLI as I believe it would make create more harm & confusion than not having the feature there.
| if schemaExists(t, db, roll.VersionedSchemaName(schema, version)) { | ||
| t.Errorf("Expected schema %q to not exist", version) | ||
| } | ||
|
|
There was a problem hiding this comment.
Is it worth testing the behaviour on rollback here too? Rolling back the migration shouldn't try to delete the version schema if it wasn't created, so attempting a rollback and asserting no error here might be worth adding.
andrew-farries
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are situatiosn were creating schema verisons is not required. This internal flag will allow to disable creating & managing these schemas when needed.
Note: I opted to not expose this flag to the CLI as I believe it would make create more harm & confusion than not having the feature there.