Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update state command to avoid returning nulls #274

Merged
merged 8 commits into from
Feb 5, 2024
Merged

Conversation

SferaDev
Copy link
Member

@SferaDev SferaDev commented Feb 5, 2024

When building the OpenAPI spec we noticed that there were a lot of empty dictionaries and arrays.
Updating the state.go query to default for {} and [].

Signed-off-by: Alexis Rico <sferadev@gmail.com>
@SferaDev SferaDev force-pushed the schema-nulls branch 2 times, most recently from bd9cfcc to 89f1be3 Compare February 5, 2024 10:35
@exekias
Copy link
Member

exekias commented Feb 5, 2024

I think this would be the way to go for tables & all other dicts 💪

Signed-off-by: Alexis Rico <sferadev@gmail.com>
Signed-off-by: Alexis Rico <sferadev@gmail.com>
Signed-off-by: Alexis Rico <sferadev@gmail.com>
Signed-off-by: Alexis Rico <sferadev@gmail.com>
@SferaDev SferaDev changed the title Remove null from tables Update state command to return empty maps Feb 5, 2024
Signed-off-by: Alexis Rico <sferadev@gmail.com>
@SferaDev SferaDev marked this pull request as ready for review February 5, 2024 15:19
@SferaDev SferaDev changed the title Update state command to return empty maps Update state command to avoid returning nulls Feb 5, 2024
@SferaDev SferaDev merged commit 9586b44 into main Feb 5, 2024
26 checks passed
@SferaDev SferaDev deleted the schema-nulls branch February 5, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants