Use the connection defined by WithRawSQLURL for backfill operations
#320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roles apply to the instance so we don't want multiple tests trying to create the same role.
Ensure that the backfills use the raw sql connection if set.
exekias
approved these changes
Mar 18, 2024
|
@exekias I don't think this PR makes sense, as the backfill will ultimately be performed by the code in the trigger. Altering the connection used to call the I think the PR should be closed. |
|
SGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#315 added the option to use a separate connection for raw SQL operations.
The same arguments about using a separate, more restrictive connection to run raw SQL operations also apply to running
upanddownSQL during backfill operations.This PR changes the backfill operation to use the alternative connection if defined.