Add a WithSQLTransformer option to rewrite user-defined SQL in up and down triggers
#329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `SQLTransformer` parameter.
Make the method take a SQL transformer.
Make the method take a SQL transformer.
andrew-farries
force-pushed
the
transform-sql-option
branch
from
8272a2c
to
fed9e35
Compare
andrew-farries
added a commit
that referenced
this pull request
Mar 27, 2024
Use the SQL transformer to transform the `up` and `down` fields of a raw SQL migration. Builds on #329 which added a `SQLTransformer` option to rewrite user-supplied SQL.
This was referenced Mar 28, 2024
andrew-farries
added a commit
that referenced
this pull request
Mar 28, 2024
Use the SQL transformer added in #329 to rewrite or reject column `DEFAULT` values. Column `DEFAULT` values are user-supplied SQL expressions that may need to be restricted or rewritten in some environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
WithSQLTransformeroption to rewrite the user-defined SQL used to defineupanddowntriggers.The intention is that the transformer be used to sanitize user-input SQL.
Transformers implement the following interface:
and are used by the
createTriggerfunction to rewrite theupordownSQL before using it in the trigger function definition.Later PRs will use the same transformer to rewrite the
upanddownvalues used in raw SQL migrations and columnDEFAULTexpressions.