Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix username in api #4

Merged
merged 5 commits into from
Aug 30, 2016
Merged

Conversation

mrbriandavis
Copy link
Contributor

These should resolve issues connecting, authorizing and using the hue lights api

Here is where the document explains the change: http://www.developers.meethue.com/documentation/configuration-api

Important bits:

**Important! The username will soon be deprecated in the bridge. It is strongly recommended not to use this and use the randomly generated bridge username.** 

…ignoring to take the supplied username and favor the actual username that is returned from Hue_s api which is a generated password
@xavier
Copy link
Owner

xavier commented Aug 28, 2016

Thanks for the PR! 👍

I hadn't closely followed the latest updates in the Hue API. I just had a quick look at the new authentication mechanism and it seems that to implement the new API properly, we should allow the devicetype to be set and update the documentation accordingly in the README and ExDoc comments. If you have some spare cycles to do this, that would be awesome. Otherwise I'll already merge this patch and work on that part later this week before publishing a new version of the package.

@mrbriandavis
Copy link
Contributor Author

mrbriandavis commented Aug 28, 2016

@xavier - added another commit that lets devicetype to be set. if this looks ok - i will update docs in the next commit.

I also have unit tests in my branch I would like to add as well.

@xavier
Copy link
Owner

xavier commented Aug 29, 2016

@mrbriandavis Thanks a lot fo this. Feel free to add your tests and documentation and I'll merge it.

@xavier xavier merged commit 08fe3b3 into xavier:master Aug 30, 2016
@xavier
Copy link
Owner

xavier commented Aug 30, 2016

👍 👍 👍 Thanks a lot for this!

The Huex.info/1 test doesn't pass because the response is a map, not a struct. It's alright I'll fix it on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants