Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to fix inheritance for es6 #17

Merged
merged 3 commits into from
Aug 31, 2019
Merged

try to fix inheritance for es6 #17

merged 3 commits into from
Aug 31, 2019

Conversation

xaviergonz
Copy link
Owner

@xaviergonz xaviergonz commented Aug 31, 2019

Fixes #15

@netlify
Copy link

netlify bot commented Aug 31, 2019

Deploy preview for mobx-keystone ready!

Built with commit 23136d0

https://deploy-preview-17--mobx-keystone.netlify.com

@xaviergonz
Copy link
Owner Author

xaviergonz commented Aug 31, 2019

@sisp care to give this branch a try and see if it fixes your CRA issue?

@coveralls
Copy link

coveralls commented Aug 31, 2019

Coverage Status

Coverage decreased (-0.04%) to 89.32% when pulling 23136d0 on fix-inheritance-es6 into 1e8e3db on master.

@sisp
Copy link
Contributor

sisp commented Aug 31, 2019

When I use the ESM bundle built from this branch with my CRA example, it works (for both "target": "es5" and "target": "es6" in tsconfig.json). :-)

@sisp
Copy link
Contributor

sisp commented Aug 31, 2019

Do you think it makes sense to add a comment in the code that justifies this "hack" and references #15 for referring to the discussion about the problem? Perhaps ES5 support can be dropped at some point and the original version can be restored and until then nobody will accidentally "improve" this part of the code.

@xaviergonz
Copy link
Owner Author

Makes total sense, added, will release this as 0.13.1

@sisp
Copy link
Contributor

sisp commented Aug 31, 2019

Thanks a lot for your efforts! You're awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-react-app: TypeError: Class constructor [...] cannot be invoked without 'new'
3 participants