Implemented a scalable control pad #477
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully fix issue #383 and fix the issue with the original version from PR #428. The original version did not include a check to see if the event server was disabled by the user. This was probably the reason some users reported issues with the control pad not working during the beta release of 2.3.X.
I falsely assumed that checking if the event server connection failed, the variable eventServerConnection would be set to null. This is only the case if hostname resolving fails. Thus, if the event server is not available and the user disabled its usage we would still be using it and do not fall back to using the HTTP input events. This has been fixed now.
In general the following changes have been made in this PR:
actual remote. I called it ControlPad to make it more clear what
its main function is.
always be square. When its width and height are both set to
match_parent, it will take the smallest of the two as the
actual size.
is sized to the maximum available space. For larger devices we still
use the old fixed sizes.