Changed: No longer ignore the .gitignore file extension. (#253)

xbmc · Apr 3, 2021 · 4069de3 · 4069de3
1 parent 6d490f8
commit 4069de3
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/kodi_addon_checker/check_files.py b/kodi_addon_checker/check_files.py
@@ -122,7 +122,7 @@ def check_file_whitelist(report: Report, file_index: list, addon_path: str):
         return
 
     whitelist = (
-        r"\.?(py|xml|gif|png|jpg|jpeg|md|txt|po|json|gitignore|markdown|yml|"
+        r"\.?(py|xml|gif|png|jpg|jpeg|md|txt|po|json|markdown|yml|"
         r"rst|ini|flv|wav|mp4|html|css|lst|pkla|g|template|in|cfg|xsd|directory|"
         r"help|list|mpeg|pls|info|ttf|xsp|theme|yaml|dict|crt|ico)?$"
     )

diff --git a/tests/test_check_files.py b/tests/test_check_files.py
@@ -2,7 +2,7 @@
 import unittest
 from os.path import abspath, dirname, join
 
-from kodi_addon_checker.check_files import check_file_permission
+from kodi_addon_checker.check_files import check_file_permission, check_file_whitelist
 from kodi_addon_checker.handle_files import create_file_index
 
 from kodi_addon_checker.common import load_plugins
@@ -39,3 +39,13 @@ def test_check_file_permission_is_None(self):
         path = join(HERE, 'test_data', 'Non-Executable_file')
         file_index = create_file_index(path)
         self.assertIsNone(check_file_permission(self.report, file_index))
+
+    def test_gitignore(self):
+        path = join(HERE, 'test_data', 'GitIgnore')
+        string = "WARN: Found non whitelisted file ending in filename {path}" \
+            .format(path=relative_path(join(path, ".gitignore")))
+        file_index = create_file_index(path)
+        check_file_whitelist(self.report, file_index, path)
+        records = [Record.__str__(r) for r in ReportManager.getEnabledReporters()[0].reports]
+        self.assertGreater(len(records), 0)
+        self.assertEqual(records[-1], string)
diff --git a/tests/test_data/GitIgnore/.gitignore b/tests/test_data/GitIgnore/.gitignore