Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know linking against IOKit framework was added for a reason. But i can't find any addon in our repo that needs this atm. Also on TVOS IOKit is a private framework which we can't link to.
I already did a binary-addons testbuild on jenkins with this and didn't see any issues.
@wsnipex @Montellese we will need a similar change to the platform repo. As far as i can see it is maintained by Pulse-Eight and @opdenkamp renamed it to platform-p8 which breaks a lot of our addons. I am not sure where to PR this change then.
Any advice on how i get this change into the platform is welcome.