Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tvos] - remove iokit linkage #15

Merged
merged 1 commit into from
Jan 19, 2016
Merged

[tvos] - remove iokit linkage #15

merged 1 commit into from
Jan 19, 2016

Conversation

Memphiz
Copy link
Member

@Memphiz Memphiz commented Dec 21, 2015

I know linking against IOKit framework was added for a reason. But i can't find any addon in our repo that needs this atm. Also on TVOS IOKit is a private framework which we can't link to.

I already did a binary-addons testbuild on jenkins with this and didn't see any issues.

@wsnipex @Montellese we will need a similar change to the platform repo. As far as i can see it is maintained by Pulse-Eight and @opdenkamp renamed it to platform-p8 which breaks a lot of our addons. I am not sure where to PR this change then.

  1. Are we going to fork the pulseeight repo and undo the rename?
  2. Are we stuck with the current platform version?
  3. Do we need to fix all addons for matching the rename?

Any advice on how i get this change into the platform is welcome.

@opdenkamp
Copy link
Member

The breakage was on purpose to allow both the old and new named lib to be used at the same time.

@opdenkamp
Copy link
Member

And no undoing of that rename if you want to be in Debian/Ubuntu some day, it was done to keep those guys happy.

@Memphiz
Copy link
Member Author

Memphiz commented Dec 21, 2015

So the idea is to follow the rename or fork to the commit before the rename? I mean for the kodi project...

@opdenkamp
Copy link
Member

For Kodi, which we want to have in Debian based dists too (unless something changed), we should upgrade things to use the new name instead. Because the two can co-exist, it doesn't have to be done in 1 go for everything, but we can update things one by one if needed. But basically, all that needs to be done is change the namespace with a big sed operating and change 2 lines in CMakeLists.txt

@Memphiz
Copy link
Member Author

Memphiz commented Dec 21, 2015

plus fixing alle the find-platform.cmake scripts in the various addons i think :)

@opdenkamp
Copy link
Member

That's the 2 lines changed in CMakeLists.txt that I meant. Just changes the generic name 'platform' into 'p8-platform'.

@opdenkamp
Copy link
Member

looks ok to me

opdenkamp pushed a commit that referenced this pull request Jan 19, 2016
[tvos] - remove iokit linkage
@opdenkamp opdenkamp merged commit fed924e into xbmc:master Jan 19, 2016
@Memphiz Memphiz deleted the tvos branch January 19, 2016 20:21
@Memphiz Memphiz restored the tvos branch January 19, 2016 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants