[plugin.video.ad6] 0.1.0 #1878

macmenco · 2018-06-05T13:40:02Z

Description

This plugin provides streams to the charity event calles "Alpe d'HuZes". The goal is to collect as much money as possible for the Dutch Cancer Society. The event takes places in the week of 6 and 7 june 2018. For the people who can't be there these streams are made available.

Checklist:

My code follows the add-on rules and piracy stance of this project.
I have read the CONTRIBUTING document
Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
add-on development wiki page.
Kodi pydocs provide information about the Python API
PEP8 codingstyle which is considered best practice but not mandatory.
This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
Development questions can be asked in the add-on development section on the Kodi forum.

enen92 · 2018-06-05T14:12:12Z

@macmenco you have to rebase on krypton. Plugins must define a type so please change the id for it to be reviewed: plugin.video.ad6 instead of plugin.ad6

enen92 · 2018-06-05T16:49:22Z

Still incorrect @macmenco

TravisBuddy · 2018-06-05T17:52:58Z

Travis Buddy

Hey Menco Bolt,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here

INFO: Checking add-on plugin.video.ad6
INFO: Created by Menco Bolt
INFO: Addon id matches folder name
INFO: Image icon exists
INFO: icon dimensions are fine 512x463
INFO: Image fanart exists
ERROR: Fanart should have either 1280x720 or 1920x1080 or 3840x2160 but it has 1501x501
ERROR: We found 1 problems and 0 warnings, please check the logfile.

TravisBuddy · 2018-06-05T17:57:38Z

Travis Buddy

Hey Menco Bolt,
please review the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

Expand here

INFO: Checking add-on plugin.video.ad6
INFO: Created by Menco Bolt
INFO: Addon id matches folder name
INFO: Image icon exists
INFO: icon dimensions are fine 512x463
INFO: Image fanart exists
ERROR: Fanart should have either 1280x720 or 1920x1080 or 3840x2160 but it has 1501x501
ERROR: We found 1 problems and 0 warnings, please check the logfile.

TravisBuddy · 2018-06-05T18:04:28Z

Travis Buddy

Hey Menco Bolt,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

macmenco · 2018-06-05T18:10:05Z

@enen92 I hope all is correct now. A question though. My plugin is for video and audio and I'm planning on adding image functionality as well. What name should I use for the plugin ?

enen92 · 2018-06-05T18:32:43Z

Unfortunately it is not. You're still carrying a lot of commits already in the branch

macmenco · 2018-06-05T20:46:57Z

@enen92 How about now ?

Rechi · 2018-06-05T21:05:37Z

no still wrong, fix it with the following commands (upstream is xbmc repo, origin is yours)

git reset --hard upstream/krypton
git checkout 4124b63 -- plugin.video.ad6
git commit -m '[plugin.video.ad6] v.0.1.0'
git push -f origin plugin.ad6

macmenco · 2018-06-06T06:48:32Z

Sorry for the trial and error. It's my first pull request. I executed the commands. Is it ok now ?

TravisBuddy · 2018-06-06T06:56:37Z

Travis Buddy

Hey Menco Bolt,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

razzeee · 2018-06-06T07:01:50Z

@macmenco yes, much better. only one commit which is yours and you only edited the code of one plugin. so far so good :)

macmenco · 2018-06-06T14:43:25Z

Would it be possible to accept the plugin before tonight? There is a livestream around 19:30 UTC+2. I know, I should have started earlier...

enen92

Please see comments. Markdown stuff are minors, the other comments are blocking. Please adjust as soon as you can and feel free to ping for a quick merge.
Thanks for the submission

plugin.video.ad6/.travis.yml

@@ -0,0 +1,20 @@
+language: python


plugin.video.ad6/README.md

@@ -0,0 +1,13 @@
+# Welcome to your addon


plugin.video.ad6/addon.xml

@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<addon id="plugin.video.ad6" name="Alpe d&#39;HuZes" version="0.1.0" provider-name="Menco Bolt">


plugin.video.ad6/addon.xml

+    <requires>
+        <import addon="xbmc.python" version="2.25.0"/>
+        <import addon="script.module.routing" version="0.2.1"/>
+


plugin.video.ad6/addon.xml

+    <extension point="xbmc.python.pluginsource" library="main.py">
+        <provides>audio video</provides>
+    </extension>
+    <extension point="xbmc.addon.metadata">


plugin.video.ad6/addon.xml

+    </extension>
+    <extension point="xbmc.addon.metadata">
+        <summary lang="nl">Dichter bij de Alpe kom je niet</summary>
+        <description lang="nl">Volg de Alpe d&#39;HuZes op de voet</description>


plugin.video.ad6/resources/language/README.md

@@ -0,0 +1 @@
+This folder will be the home of your translations


plugin.video.ad6/resources/lib/README.md

@@ -0,0 +1,7 @@
+# Readme


plugin.video.ad6/resources/lib/plugin.py

+            url = prefix % stream['url_id']
+            folder = True
+        li = ListItem(label=stream['title'])
+        li.setIconImage(get_logo(stream['logo']))


plugin.video.ad6/tests/README.md

@@ -0,0 +1,2 @@
+# Tests


TravisBuddy · 2018-06-06T21:10:36Z

Travis Buddy

Hey Menco Bolt,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

macmenco changed the title ~~Plugin.ad6~~ [plugin.ad6] v0.1.0 Jun 5, 2018

macmenco changed the title ~~[plugin.ad6] v0.1.0~~ [plugin.ad6] 0.1.0 Jun 5, 2018

macmenco changed the title ~~[plugin.ad6] 0.1.0~~ [plugin.video.ad6] 0.1.0 Jun 5, 2018

enen92 requested changes Jun 6, 2018

View reviewed changes

[plugin.video.ad6] v.0.1.0

bf976b6

enen92 approved these changes Jun 6, 2018

View reviewed changes

enen92 merged commit 4fc41e7 into xbmc:krypton Jun 6, 2018

macmenco deleted the plugin.ad6 branch June 7, 2018 11:34

enen92 mentioned this pull request Jun 9, 2018

Html characters in addon title xbmc/generator-kodi-addon#37

Open

		@@ -0,0 +1,28 @@
		<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
		<addon id="plugin.video.ad6" name="Alpe d'HuZes" version="0.1.0" provider-name="Menco Bolt">

		@@ -0,0 +1 @@
		This folder will be the home of your translations

[plugin.video.ad6] 0.1.0 #1878

[plugin.video.ad6] 0.1.0 #1878

Conversation

macmenco commented Jun 5, 2018 • edited Loading

Description

Checklist:

enen92 commented Jun 5, 2018 • edited Loading

enen92 commented Jun 5, 2018

TravisBuddy commented Jun 5, 2018

Travis Buddy

1st Build

TravisBuddy commented Jun 5, 2018

Travis Buddy

1st Build

TravisBuddy commented Jun 5, 2018

Travis Buddy

macmenco commented Jun 5, 2018

enen92 commented Jun 5, 2018

macmenco commented Jun 5, 2018

Rechi commented Jun 5, 2018

macmenco commented Jun 6, 2018

TravisBuddy commented Jun 6, 2018

Travis Buddy

razzeee commented Jun 6, 2018

macmenco commented Jun 6, 2018

enen92 left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

TravisBuddy commented Jun 6, 2018

Travis Buddy

macmenco commented Jun 5, 2018 •

edited

Loading

enen92 commented Jun 5, 2018 •

edited

Loading