Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.mlbtv@matrix] 2022.5.5+matrix.1 #3989

Merged
merged 1 commit into from
May 7, 2022
Merged

[plugin.video.mlbtv@matrix] 2022.5.5+matrix.1 #3989

merged 1 commit into from
May 7, 2022

Conversation

eracknaphobia
Copy link

Add-on details:

Watch every out-of-market regular season game in the office or on the go. The #1 LIVE
Streaming Sports Service

Description of changes:

        - options to automatically skip breaks and non-action pitches
        - option to start at specific inning
        - improved Big Inning stream retrieval
        - perfect game / no hitter flags
        - fix free games only

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

break

# wait 1 second until next loop iteration
xbmc.sleep(1000)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed? You already wait at the beginning of the method. Maybe you want to waitForAbort here and just check abortRequested in the beginning?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonywagner Can you verify this is needed?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are right, that's probably not necessary. I will test and likely drop it in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants