Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add omega repo #2407

Merged
merged 1 commit into from
Feb 20, 2023
Merged

add omega repo #2407

merged 1 commit into from
Feb 20, 2023

Conversation

fuzzard
Copy link
Contributor

@fuzzard fuzzard commented Feb 12, 2023

Description

Omega Repo

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@fuzzard fuzzard requested a review from ronie February 12, 2023 22:27
@ronie
Copy link
Member

ronie commented Feb 12, 2023

i don't recall if it's actually needed, but it might be best to first create the omega branch in all the repos before pulling this one in.

other than that, looks good to me.

@fuzzard
Copy link
Contributor Author

fuzzard commented Feb 12, 2023

Ok, i'll look into that at the end of the week.

Question regarding this however, just for future reference, what if an api version changes during a release cycle for whatever reason? do we just update in here, or in general are there processes in place where it doesnt actually matter for this?

@ronie
Copy link
Member

ronie commented Feb 13, 2023

i don't think we ever changed an api version halfway through a release cycle and i don't think we ever should :-)

but since we specify the 'minimum' required version here, it might not have much of an impact if we did do an api bump.

@fuzzard
Copy link
Contributor Author

fuzzard commented Feb 19, 2023

Have created an omega branch, and opened PR's to clean it up (most branches created off master, then a PR to bring it up to date with yml/other stuff)

#2410
xbmc/repo-resources#352
xbmc/repo-plugins#4258
xbmc/repo-skins#385

repo-webinterfaces has just been branched (no cleanup PR needed)
repo-scrapers i PR'd and merged

@enen92 enen92 merged commit a18b708 into xbmc:master Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants