Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] - allow detailedmode for xbmcgui.Dialog().select() / multiselect() #10586

Merged
merged 1 commit into from
Oct 16, 2016
Merged

[python] - allow detailedmode for xbmcgui.Dialog().select() / multiselect() #10586

merged 1 commit into from
Oct 16, 2016

Conversation

phil65
Copy link
Contributor

@phil65 phil65 commented Sep 29, 2016 •
edited
Loading

Allows to use the detailedmode for our Dialog().select() and Dialog().multiselect() methods

  1. by adding a bool parameter called "useDetails"
  2. by being able to pass xbmcgui listitems instead of strings so that these items can carry a label2 and/or an icon.

@ronie @tamland

@mention-bot
Copy link

@phil65, thank you for improving Kodi! According to the last 5 commits, we found the potential reviewers: @Paxxi, @tamland and @AlwinEsch. Final approval needs to be given by the component maintainer.

@ronie
Copy link
Member

ronie commented Sep 29, 2016

tested and works fine on my end. thx!

@ganesh1515
Copy link

Thankyou

Sent from my iPhone

On Sep 29, 2016, at 11:36 PM, ronie <notifications@github.commailto:notifications@github.com> wrote:

tested and works fine on my end. thx!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//pull/10586#issuecomment-250502710, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AVewX0L4j-J99AUSYtEIiKFh5agLOfEsks5qu9sCgaJpZM4KJj-p.

tamland
tamland reviewed Oct 1, 2016
View reviewed changes
xbmc/interfaces/legacy/Dialog.cpp
@@ -101,7 +101,7 @@ namespace XBMCAddon
}


int Dialog::select(const String& heading, const std::vector<String>& list, int autoclose, int preselect)
int Dialog::select(const String& heading, const std::vector<Alternative<String, const ListItem* > > & list, int autoclose, int preselect, bool useDetails)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tamland
tamland reviewed Oct 1, 2016
View reviewed changes
xbmc/interfaces/legacy/Dialog.cpp

String listLine;
for(unsigned int i = 0; i < list.size(); i++)
for (const auto item : list)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@phil65 phil65 force-pushed the python_selectdialog branch 2 times, most recently from c39392b to 066ee66 Compare October 1, 2016 14:40
@phil65
Copy link
Contributor Author

phil65 commented Oct 1, 2016

@tamland updated, including the docs.

@tamland tamland added Type: Feature non-breaking change which adds functionality Component: Python v18 Leia labels Oct 2, 2016
@tamland
Copy link
Member

tamland commented Oct 2, 2016

looks good

@phil65 phil65 force-pushed the python_selectdialog branch 2 times, most recently from 6d2b426 to e331872 Compare October 16, 2016 19:23
@phil65
Copy link
Contributor Author

phil65 commented Oct 16, 2016

Updated to include @python_v17 remarks.

@MartijnKaijser
Copy link
Member

Jenkins build and merge

@jenkins4kodi jenkins4kodi merged commit e1d0050 into xbmc:master Oct 16, 2016
@MartijnKaijser MartijnKaijser added this to the Krypton 17.0-beta4 milestone Oct 16, 2016
@phil65 phil65 deleted the python_selectdialog branch October 17, 2016 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamland tamland tamland left review comments

Assignees
No one assigned
Labels
API change: Python Component: Python Type: Feature non-breaking change which adds functionality v17 Krypton
Projects
None yet
Milestone
Krypton 17.0-beta4
Development

Successfully merging this pull request may close these issues.
7 participants
@phil65 @mention-bot @ronie @ganesh1515 @tamland @MartijnKaijser @jenkins4kodi