Fix analog sticks #11616
Merged
Fix analog sticks #11616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garbear
force-pushed
the
fix-analog-sticks
branch
6 times, most recently
from
f110eb3
to
c5fdf0d
Compare
|
I split the cleanup commits into #11621. I also simplified the detection code by removing checks for a quirk that a following PR will addresses. jenkins build this please |
This completes a TODO left in bd6697b.
… the detection process starts. Before the associated fix in peripheral.joystick, updates were only sent for updated axes. Now, peripheral.joystick sends events for every known axis on every frame. This means that we can reliably detect an initial position of the axis. There is one caveat - on OSX, axes are not reported until first *moved*. This means that until a trigger is pressed at least once, its position is unknown. This breaks button mapping, but the next attempt should work.
This was referenced Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first fix is for a logic error in #11571 that breaks analog sticks.
Also included is a fix for an edge case documented in bd6697b.
Another two fixes have been PRed to xbmc/peripheral.joystick#84