webserver improvements #12072
Merged
webserver improvements #12072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make IHTTPRequestHandler::Create() const * make IHTTPRequestHandler::CanHandleRequest() const * cleanup usage of virtual and add override keyword * add CWebServer::FindRequestHandler()
Montellese
added
Type: Cleanup
|
jenkins build this please |
Rechi
reviewed
May 10, 2017
xbmc/network/WebServer.cpp
Outdated
| std::multimap<std::string, std::string> getValues; | ||
| HTTPRequestHandlerUtils::GetRequestHeaderValues(request.connection, MHD_GET_ARGUMENT_KIND, getValues); | ||
|
|
||
| CLog::Log(LOGDEBUG, "CWebServer[%hu] [IN] %s %s %s", m_port, request.version, GetHTTPMethod(request.method).c_str(), request.pathUrlFull.c_str()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Montellese
force-pushed
the
webserver_improvements
branch
from
d2427a2
to
8ca580c
Compare
|
jenkins build this please |
|
compiled now. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into what's new in libmicrohttpd I also read through the code in
CWebServeret al. and did some code cleanup / refactoring.The only functional change (which should not make any difference for clients) is bf9126f which replaces our "custom" handling of basic authentication with the one provided by libmicrohttpd.
The rest of the changes are refactorings which move code blocks into separate methods to make the libmicrohttpd callback implementations more readable and some C++11-ifying.
Types of change
Checklist: