Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup due to x64 build changes #12382

Merged
merged 1 commit into from
Apr 19, 2018
Merged

Cleanup due to x64 build changes #12382

merged 1 commit into from
Apr 19, 2018

Conversation

razzeee
Copy link
Member

@razzeee razzeee commented Jun 28, 2017

Description

MERGE THIS AFTER 17 IS EOL, IT WILL NEED JENKINS CHANGES

Remove some unused scripts that were left.

Motivation and Context

Cleanup

How Has This Been Tested?

Has not been tested yet, I'm acting on the knowledge by @Rechi

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

@razzeee razzeee requested a review from Rechi June 28, 2017 08:27
@razzeee razzeee added the WIP PR that is still being worked on label Jun 28, 2017
@Rechi Rechi added the On hold PR that is not currently being worked on (e.g. waiting for a 3rd-party release or feedback) label Jun 28, 2017
Rechi
Rechi approved these changes Jun 28, 2017
View reviewed changes
Copy link
Member

@Rechi Rechi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are correct

Jenkins WIN-32 job has to be changed after v17 EOL and before this gets merged

@razzeee razzeee removed the WIP PR that is still being worked on label Jun 28, 2017
Rechi
Rechi reviewed Nov 9, 2017
View reviewed changes
project/Win32BuildSetup/readme.txt Outdated
@@ -3,7 +3,7 @@ Prerequisites for building a Kodi for Windows installer:
1) See http://kodi.wiki/view/HOW-TO:Compile_for_Windows

Usage:
1) Run BuildSetup.bat in project\Win32BuildSetup
1) Run BuildSetup.bat in tools\buildsteps\windows\{win32|x64}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@Paxxi
Copy link
Member

Paxxi commented Nov 11, 2017

I think we should fix the naming here, win32 is a platform and not an architecture so folders should be x86/x64/arm-win32/uwp to make it consistent. Win32 could be named desktop as well, but win32 is a bit shorter

@razzeee
Copy link
Member Author

razzeee commented Nov 11, 2017

I like what paxxi is suggesting

@Rechi Rechi added Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia and removed On hold PR that is not currently being worked on (e.g. waiting for a 3rd-party release or feedback) labels Apr 19, 2018
@Rechi Rechi added this to the Leia 18.0-alpha2 milestone Apr 19, 2018
@Rechi Rechi merged commit 5295d8e into xbmc:master Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rechi Rechi Rechi approved these changes

Assignees
No one assigned
Labels
Platform: Windows Type: Cleanup non-breaking change which removes non-working or unmaintained functionality v18 Leia
Projects
None yet
Milestone
Leia 18.0-alpha2
Development

Successfully merging this pull request may close these issues.
3 participants
@razzeee @Paxxi @Rechi