[xbmc][win32] Fix a crash for subtitle rendering in 4k on amd cards #12516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paxxi
added
Backport: Done
Type: Fix
AMD drivers crashes when we try to allocate a texture 5073 pixels wide. This caps our texture to the screen width.
afedchin
approved these changes
Jul 17, 2017
garbear
reviewed
Jul 17, 2017
| @@ -205,8 +205,8 @@ bool convert_quad(ASS_Image* images, SQuads& quads) | |||
| if (quads.count == 0) | |||
| return false; | |||
|
|
|||
| if (quads.size_x > (int)g_Windowing.GetMaxTextureSize()) | |||
| quads.size_x = g_Windowing.GetMaxTextureSize(); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMD drivers crashes when we try to allocate a texture
5073 pixels wide. This caps our texture to the screen width.
backport #12515
This doesn't update libass, there's more changes coming there.
The backport was tested with the updated libass so didn't want to take any chances there for now.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of change
Checklist: