Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] always pass compiler to libdvd #13802

Merged
merged 1 commit into from
Apr 22, 2018
Merged

Conversation

Rechi
Copy link
Member

@Rechi Rechi commented Apr 21, 2018

Description

The same compiler used for Kodi should be used for libdvd libs.

Motivation and Context

setting CMAKE_C_COMPILER (eg to clang or a specific gcc version) should result in libdvd also using that compiler

How Has This Been Tested?

generated project with default compiler, clang and gcc-8
build libdvd with each of them

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the Code guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have added tests to cover my change
  • All new and existing tests passed

Copy link
Member

@wsnipex wsnipex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rechi Rechi merged commit 3e5f63e into xbmc:master Apr 22, 2018
@Rechi Rechi deleted the fix/compiler branch April 22, 2018 06:41
@Rechi Rechi added this to the Leia 18.0-alpha2 milestone Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants