Fix parent directory ".." not exiting plugins providing multiple types

[garbear]

This fixes unable being able to exit plugins by selecting ".." at the plugin's root when the plugin provides multiple types.

When a plugin provides multiple types, it is launched with the context as URL options, e.g. plugin://addon.id/?content_type=video.

When the ".." at the plugin root is selected, plugins with a single type updated to plugin:// and exit. This is the expected behavior.

Plugins with multiple types, however, update with plugin://addon.id/, which refreshes the root window and doesn't exit.

To fix this, we make the parent directory of the URL with options but no file equal to plugin://, which exits the plugin.

Also includes a small validation check.

Motivation and Context

Reported here: garbear#94

How Has This Been Tested?

Tested on Windows 10 with IAGL. Selecting ".." correctly exits the plugin.

This may have side effects, but I'm not aware of any.

Types of change

• Bug fix (non-breaking change which fixes an issue)
• Clean up (non-breaking change which removes non-working, unmaintained functionality)
• Improvement (non-breaking change which improves existing functionality)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that will cause existing functionality to change)
• Cosmetic change (non-breaking change that doesn't touch code)
• None of the above (please explain below)

[garbear]

Any Python guys wanna chime in? Do any plugins use URL options as a subdirectory?

[garbear]

Confirmed fixed in garbear#94

[AkariDN]

@garbear sorry for late reply, but yes, your PR changes plugin parenting rules and breaks some video database functionality. If you only want to make the parent directory of the URL with options but no file equal to plugin://, but your changes also removes both filename and options if file is not empty and leaves options if file is empty.

// wrong, should be plugin://addon.id/filename/
plugin://addon.id/filename/?options -> plugin://addon.id/
// correct
plugin://addon.id/filename/ -> plugin://addon.id/
// wrong, should be plugin://
plugin://addon.id/?options -> plugin://?options
// correct
plugin://addon.id/ -> plugin://

[ksooo]

@garbear this also breaks the guiinfo label "ListItem.Path" (and possibly others) for plugin items. See https://forum.kodi.tv/showthread.php?tid=330696&pid=2767502#pid2767502 ff

[garbear]

@ksooo Fixed by #14434, just awaiting a comment