Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RetroPlayer: Fix no game input after controller shuts off #14437

Merged
merged 1 commit into from
Sep 22, 2018

Conversation

garbear
Copy link
Member

@garbear garbear commented Sep 14, 2018

This fixes input dropping and never resuming in the game when a controller disconnects, such as for low-battery situations.

Motivation and Context

Reported here.

How Has This Been Tested?

Test builds: https://github.com/garbear/xbmc/releases

Tested by unplugging/replugging controller on OSX.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

This fixes input dropping and never resuming in the game when a controller
disconnects, such as for low-battery situations.
@garbear
Copy link
Member Author

garbear commented Sep 16, 2018

Test builds uploaded to https://github.com/garbear/xbmc/releases

@garbear
Copy link
Member Author

garbear commented Sep 20, 2018

I have a report that the problem still exists with a PS3 controller, but manually unplugging/replugging controllers on my macbook is no longer broken, so I think I merge this and continue looking into the PS3 controller problem later.

@garbear garbear merged commit f023cde into xbmc:master Sep 22, 2018
@garbear garbear deleted the fix-disconnected branch September 22, 2018 12:23
@Rechi Rechi added this to the Leia 18.0-beta3 milestone Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Games Component: Input Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants