Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmake] partly revert #15642 to have wayland and GBM working #15804

Merged
merged 1 commit into from
Mar 23, 2019
Merged

[cmake] partly revert #15642 to have wayland and GBM working #15804

merged 1 commit into from
Mar 23, 2019

Conversation

AlwinEsch
Copy link
Member

@AlwinEsch AlwinEsch commented Mar 23, 2019 •
edited
Loading

Description

With the include of Platform.cmake to have for addons is the GBM_RENDER_SYSTEM not defined, this becomes set from "./tools/depends/target/Toolchain.cmake" but on a other place.

This remove the change, but after the release must be the cmake workflow cleaned up. There are some hen and egg problems and maybe some hidden faults where a value becomes checked which never available.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@AlwinEsch
[cmake] partly revert xbmc#15642 to have wayland and GBM working
40a5716 
With the include of Platform.cmake to have for addons is the
GBM_RENDER_SYSTEM not defined, this becomes set from
"./tools/depends/target/Toolchain.cmake" but on a other place.

This remove the change, but after the release must be the cmake
workflow cleaned up. There are some hen and egg problems and
maybe some hidden faults where a value becomes checked which
becomes never available.
@AlwinEsch AlwinEsch added Type: Fix non-breaking change which fixes an issue CMake v18 Leia labels Mar 23, 2019
@AlwinEsch AlwinEsch added this to the Leia 18.2-rc1 milestone Mar 23, 2019
@AlwinEsch AlwinEsch merged commit 98d18d0 into xbmc:master Mar 23, 2019
@AlwinEsch AlwinEsch deleted the partly-fix-cmake branch March 23, 2019 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CMake Type: Fix non-breaking change which fixes an issue v18 Leia
Projects
None yet
Milestone
Leia 18.2-rc1
Development

Successfully merging this pull request may close these issues.
1 participant
@AlwinEsch