Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed windows 7 environment compatibility #17122

Merged
merged 1 commit into from
Jan 4, 2020
Merged

Conversation

CastagnaIT
Copy link
Collaborator

Description

The problem was introduced with python 3 PR, with the commit 615a55e
that adds the reference to Mincore.lib.

Microsoft documentation say:

Binaries that link to MinCore.lib or MinCore_Downlevel.lib are not designed to work on Windows 7

https://docs.microsoft.com/en-us/windows/win32/apiindex/windows-8-api-sets
(so Mincore.lib is introduced to work only from Windows 8 and up)

The microsoft documentation seems to have not been updated in all its parts, there are several discussions on the network for this documentation leak, that causing confusion.

By using an updated version of Dependency Walker, i was able to see the list of missing api dependencies, one of these is Api-ms-win-core-version-l1-1-0.dll,
if you are looking for one of the API that using this dll like: https://docs.microsoft.com/it-it/windows/win32/api/winver/nf-winver-getfileversioninfoa
you can see that they point to version.lib.

Then to maintain compatibility with the old Windows 7 is necessary to change MinCore.lib to version.lib (on the network you can find other software that has made this change)

I also had to add crypt32.lib, for the openssl? can it be? without it does not compile

I'm not an expert in this kind of thing, but i have deduced this from reading the documentation

Motivation and Context

As reported to issue #16820 all builds after the date 10/11/19 are all broken for windows 7 environment

How Has This Been Tested?

Tested on my virtualbox, builded with latest master branch,
the test in real environment was performed by a user, confirmed in the opened issue

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@Paxxi
Copy link
Member

Paxxi commented Jan 4, 2020

I don't have a machine to test this on but it looks fine to me.

Thank you @CastagnaIT 😀

@Paxxi Paxxi merged commit 9fcd740 into xbmc:master Jan 4, 2020
@CastagnaIT CastagnaIT deleted the win7fix branch October 6, 2021 11:36
@CastagnaIT CastagnaIT mentioned this pull request Mar 28, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants