Fixed windows 7 environment compatibility #17122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem was introduced with python 3 PR, with the commit 615a55e
that adds the reference to Mincore.lib.
Microsoft documentation say:
https://docs.microsoft.com/en-us/windows/win32/apiindex/windows-8-api-sets
(so Mincore.lib is introduced to work only from Windows 8 and up)
The microsoft documentation seems to have not been updated in all its parts, there are several discussions on the network for this documentation leak, that causing confusion.
By using an updated version of Dependency Walker, i was able to see the list of missing api dependencies, one of these is Api-ms-win-core-version-l1-1-0.dll,
if you are looking for one of the API that using this dll like: https://docs.microsoft.com/it-it/windows/win32/api/winver/nf-winver-getfileversioninfoa
you can see that they point to version.lib.
Then to maintain compatibility with the old Windows 7 is necessary to change MinCore.lib to version.lib (on the network you can find other software that has made this change)
I also had to add crypt32.lib, for the openssl? can it be? without it does not compile
I'm not an expert in this kind of thing, but i have deduced this from reading the documentation
Motivation and Context
As reported to issue #16820 all builds after the date 10/11/19 are all broken for windows 7 environment
How Has This Been Tested?
Tested on my virtualbox, builded with latest master branch,
the test in real environment was performed by a user, confirmed in the opened issue
Screenshots (if appropriate):
Types of change
Checklist: