Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix VideoPlayer.UniqueID() infolabel #17584

Merged
merged 1 commit into from
Apr 3, 2020
Merged

fix VideoPlayer.UniqueID() infolabel #17584

merged 1 commit into from
Apr 3, 2020

Conversation

ronie
Copy link
Member

@ronie ronie commented Mar 29, 2020

call it a brainfart, call it lack of testing, but part of #17340 was missing, resulting in a non-functional VideoPlayer.UniqueID() infolabel.

i've now added the missing magic to GUIInfoManager to bring it back to life.

@ronie ronie added Type: Fix non-breaking change which fixes an issue Component: GUI engine v19 Matrix labels Mar 29, 2020
@ronie ronie added this to the Matrix 19.0-alpha 1 milestone Mar 29, 2020
@jenkins4kodi jenkins4kodi added the Rebase needed PR that does not apply/merge cleanly to current base branch label Apr 3, 2020
@jenkins4kodi jenkins4kodi removed the Rebase needed PR that does not apply/merge cleanly to current base branch label Apr 3, 2020
@ronie ronie merged commit 8da4156 into xbmc:master Apr 3, 2020
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Apr 6, 2020
fix VideoPlayer.UniqueID() infolabel
Maven85 pushed a commit to Maven85/kodi that referenced this pull request May 5, 2020
fix VideoPlayer.UniqueID() infolabel
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 3, 2020
fix VideoPlayer.UniqueID() infolabel
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
fix VideoPlayer.UniqueID() infolabel
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 4, 2020
fix VideoPlayer.UniqueID() infolabel
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 5, 2020
fix VideoPlayer.UniqueID() infolabel
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
fix VideoPlayer.UniqueID() infolabel
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
fix VideoPlayer.UniqueID() infolabel
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 6, 2020
fix VideoPlayer.UniqueID() infolabel
Maven85 pushed a commit to Maven85/kodi that referenced this pull request Aug 7, 2020
fix VideoPlayer.UniqueID() infolabel
@ronie ronie deleted the fix-uniqueid branch July 31, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GUI engine Type: Fix non-breaking change which fixes an issue v19 Matrix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants