Don't send UNFOCUS_ALL after touch action #17618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peak3d
added
Type: Fix
garbear
approved these changes
Apr 5, 2020
7 tasks
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Apr 6, 2020
Don't send UNFOCUS_ALL after touch action
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
May 5, 2020
Don't send UNFOCUS_ALL after touch action
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 3, 2020
Don't send UNFOCUS_ALL after touch action
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
Don't send UNFOCUS_ALL after touch action
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 4, 2020
Don't send UNFOCUS_ALL after touch action
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 5, 2020
Don't send UNFOCUS_ALL after touch action
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
Don't send UNFOCUS_ALL after touch action
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
Don't send UNFOCUS_ALL after touch action
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 6, 2020
Don't send UNFOCUS_ALL after touch action
Maven85
pushed a commit
to Maven85/kodi
that referenced
this pull request
Aug 7, 2020
Don't send UNFOCUS_ALL after touch action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove code part where GUI_MSG_UNFOCUS_ALL is send after touch action finishes.
Motivation and Context
After touch tap / gesture end on Android the current code fires a GUI_MSG_UNFOCUS_ALL which removes the focus from the toched element. The missing feedback is a very bad user experience.
This PR removes this piece of code and assumes, that touch / mouse events focus / unfocus the correct elements.
How Has This Been Tested?
Launch kodi (skin estouchy) on any Android phone, click on any element.
Types of change