-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[clang-format] disable for all arrays in LangCodeExpander.cpp #17669
Conversation
understand the reasoning, but i think the approach is wrong. I would look to wrap the individual arrays in an on/off. Reason being is if someone were to add something else, that just happened to be inside this large (~1000 LOC) on/off (think non array code potentially) then clang formatting wont apply, even though it should. I know the likely hood is slim, but I lean more towards the explicit side of things at times, so i'll let others comment. |
sounds reasonable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
Thanks @howie-f |
thanks @phunkyfish clang-format off was your hint 😉 |
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
[clang-format] disable for all arrays in LangCodeExpander.cpp
Description
follow-up pr to #17626
we need to disable clang-format on all arrays instead of only the last one
Motivation and Context
see https://jenkins.kodi.tv/job/BuildMulti-PR/15513/artifact/PR17665.diff of
PR #17665
clang-format doesn't always work properly in those cases
Types of change
Checklist:
@fuzzard would you please have a quick look (real 1-liner this time)