-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Change to MediaCodecList.getCodecInfos() #21421
Conversation
xbmc/platform/android/media/decoderfilter/MediaCodecDecoderFilterManager.cpp
Outdated
Show resolved
Hide resolved
are you able to attach a test build arm64? |
Two versions to test based on the constructor's parameters: |
63568bb
to
33c150a
Compare
70616c2
to
14b7a74
Compare
tested on my phone regular version works as before on android 8 |
I can test on android 12, whats the test cases you need looked at? hit me up on slack @CastagnaIT |
xbmc/cores/VideoPlayer/DVDCodecs/Audio/DVDAudioCodecAndroidMediaCodec.cpp
Outdated
Show resolved
Hide resolved
xbmc/cores/VideoPlayer/DVDCodecs/Video/DVDVideoCodecAndroidMediaCodec.cpp
Show resolved
Hide resolved
xbmc/platform/android/media/decoderfilter/MediaCodecDecoderFilterManager.cpp
Outdated
Show resolved
Hide resolved
14b7a74
to
1910e68
Compare
well then let‘s go. thanks again @joseluismarti |
Description
MediaCodecList object uses two static methods to get available codecs, these two methods are deprecated in API level 21.
I propose to use the non-static
getCodecInfos()
method instead, it returns a list of MediaCodecInfo objects.The constructor has a parameter with two possible values:
ALL_CODECS
: Enumerate all codecs, even ones that are not suitable for regular (buffer-to-buffer) decoding or encoding, such as secure codecs (.secure).REGULAR_CODECS
: Enumerate only codecs that are suitable for regular (buffer-to-buffer) decoding or encoding. These are the same codecs that are returned by the deprecated methods.This PR depends on (xbmc/libandroidjni#34).
How has this been tested?
Runtime tested on AFTV (Android TV 9)
Types of change
Checklist: