Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Migrate more modules to TARGET usage #23748

Merged
merged 4 commits into from
Sep 14, 2023
Merged

Conversation

fuzzard
Copy link
Contributor

@fuzzard fuzzard commented Sep 10, 2023

Description

Migrate more modules to TARGET usage

Motivation and context

Migrate more modules to target usage.
@sundermann @wsnipex of note for webOS is the commit to "simplify" FindWaylandProtocolsWebOS. As the pc file isnt from an upstream source, i felt its just easier to drop it. We are only looking for the xml files, so a simple find_path should be fine. I contemplated dropping the find module completely and moving the find_path to the ExtraTargets.cmake file, but i can see the argument for it being a dependency to check/find, so at least you get output in the configure step. Let me know if you would prefer it the way it was, but i dont see a point to make it a full TARGET style find module.

How has this been tested?

Build aarch64 macos and shoehorning webos find checks.

What is the effect on users?

N/A

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

fuzzard added 2 commits September 11, 2023 14:03
Remove manual pkgconfig file from dependency build. It hardcodes things, and isnt
needed for our purposes as all.
@fuzzard
Copy link
Contributor Author

fuzzard commented Sep 13, 2023

Jenkins build this please

@fuzzard fuzzard merged commit fb67e7c into xbmc:master Sep 14, 2023
1 check passed
@fuzzard fuzzard deleted the cmake_target2 branch September 14, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant