Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Video] Fix crash when scan to library on a directory containing new movies #23767

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

joseluismarti
Copy link
Contributor

Description

This function tries to access the VideoInfoTag but it's not yet available at that time.

It's enough to get the path from the item (video file).

Motivation and context

Null pointer dereference.

How has this been tested?

Scan new movies and check add to the library.

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: Video v21 Omega labels Sep 15, 2023
@ksooo ksooo added this to the Omega 21.0 Beta 1 milestone Sep 15, 2023
@ksooo ksooo merged commit a26677f into xbmc:master Sep 15, 2023
1 check passed
@joseluismarti joseluismarti deleted the NoVideoInfoTag branch September 15, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Video Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants