[Estuary][Estouchy] Retire Favourites dialog, use Favourites window instead. #23861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
added
Type: Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Favourites window (MyFavourites.xml) was introduced with Nexus. Intention is to replace the Favourites dialog (DialogFavourites.xml).
Estuary was adapted for Nexus already. This PR only contains a fix for a small oversight and finally removes DialogFavourites.xml from the skin.
Estouchy was not adapted for Nexus. This PR comes will all the required changes to switching from the dialog to the window.
Similar to Estuary, two views are supported:
@jjd-uk I want to have this in for Omega beta 1 and hope you find some time for a review soon.