Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Teletext] Only override the language code from header if it is actua… #23890

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

enen92
Copy link
Member

@enen92 enen92 commented Oct 8, 2023

…lly valid

Description

In our teletext implementation we always override the national subset which might have been received from a Packet X/28 (see https://www.etsi.org/deliver/etsi_en/300700_300799/300706/01.02.01_60/en_300706v010201p.pdf table 33) with the page header country code. The issue is that even if the header doesn't have a valid subset (0x00 countrycode) we set it anyway overriding any valid value previously set.

Motivation and context

Fix #23882

How has this been tested?

Runtime tested against the provided sample as well as my other test samples (and actual tv channels):

What is the effect on users?

Some charsets were incorrectly setcausing visual glitches and unknown characters in the teletext browser.

Screenshots (if appropriate):

Before:
image

Now:
image

Other tested samples with different charsets:
(pt)
image

(spanish)
image

(uk)
image

(russian)
image

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

@enen92 enen92 added Type: Fix non-breaking change which fixes an issue v21 Omega Component: Teletext labels Oct 8, 2023
@enen92 enen92 added this to the Omega 21.0 Beta 1 milestone Oct 8, 2023
@ninja-
Copy link

ninja- commented Oct 8, 2023

Thanks! I would never expect the issue to be that far away from Teletext.cpp...

Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@enen92 enen92 merged commit a57d886 into xbmc:master Oct 9, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Teletext Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teletext decoder - no Polish diacritics
3 participants