[Teletext] Only override the language code from header if it is actua… #23890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lly valid
Description
In our teletext implementation we always override the national subset which might have been received from a Packet X/28 (see https://www.etsi.org/deliver/etsi_en/300700_300799/300706/01.02.01_60/en_300706v010201p.pdf table 33) with the page header country code. The issue is that even if the header doesn't have a valid subset (0x00 countrycode) we set it anyway overriding any valid value previously set.
Motivation and context
Fix #23882
How has this been tested?
Runtime tested against the provided sample as well as my other test samples (and actual tv channels):
What is the effect on users?
Some charsets were incorrectly setcausing visual glitches and unknown characters in the teletext browser.
Screenshots (if appropriate):
Before:
Now:
Other tested samples with different charsets:
(pt)
(spanish)
(uk)
(russian)
Types of change