Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[video] Fix 'Play using' offering RetroPlayer for playback of iso bd/dvd disc images. #23983

Merged
merged 1 commit into from
Oct 22, 2023
Merged

[video] Fix 'Play using' offering RetroPlayer for playback of iso bd/dvd disc images. #23983

merged 1 commit into from
Oct 22, 2023

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Oct 22, 2023

Yet another dynpath issue...

Fixes a problem reported in the forum, that "Play using..." offers RetroPlayer for playback of DB/DVD iso disc images.

screenshot00003

@CrystalP fyi

Runtime-tested on macOS, latest master + external player VLC + bd iso image.

@enen92 here we go again... thx for reviewing.

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: Video v21 Omega labels Oct 22, 2023
@ksooo ksooo added this to the Omega 21.0 Beta 2 milestone Oct 22, 2023
@ksooo ksooo requested a review from enen92 October 22, 2023 15:02
enen92
enen92 approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@enen92 enen92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe since it only affects context menus, however I hope a proper fiz for v22 can be devised by changing the actual classes to dynpath. That will certainly cause regressions everywhere, that's the reason for approving this hack.

@ksooo
Copy link
Member Author

ksooo commented Oct 22, 2023

that's the reason for approving this hack.

For the records: The hack was there before this PR. I just fixed it to actually work. :-)

@ksooo
Copy link
Member Author

ksooo commented Oct 22, 2023

Jenkins errors are unrelated.

@ksooo ksooo merged commit b3de3c2 into xbmc:master Oct 22, 2023
1 of 2 checks passed
@ksooo ksooo deleted the video-fix-play-using-offered-players branch October 22, 2023 16:54
@CrystalP
Copy link
Contributor

Thanks. It also sped up the opening of the context menu for items on home page (recently added for ex.) and in library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enen92 enen92 enen92 approved these changes

Assignees
No one assigned
Labels
Component: Video Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Milestone
Omega 21.0 Beta 2
Development

Successfully merging this pull request may close these issues.
3 participants
@ksooo @CrystalP @enen92