Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macOS][Jenkins] migrate from altool to notarytool #24032

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

kambala-decapitator
Copy link
Contributor

@kambala-decapitator kambala-decapitator commented Oct 31, 2023

Description

Now using notarytool instead of the deprecated altool to notarize the built dmg. Authorization changed from user/password to ASC API key.

Motivation and context

altool can no longer be used for notarization starting 01.11.2023. Email from Apple:

We’re following up on our previous email announcing that you’ll soon need to transition to the notarytool command-line utility (included with Xcode 13 or later) in order to continue notarizing your macOS software with Apple. Notarizing software with altool was deprecated in Xcode 13, and the Apple notary service will no longer accept uploads from altool as of November 1, 2023. Existing notarized software will continue to function properly.

For information on notarizing your apps, read TechNote TN3147: Migrating to the latest notarization tool.

How has this been tested?

Created test job on Jenkins with the necessary changes, checked logs for notarization success and tested on Mac. Successful build: https://jenkins.kodi.tv/view/All/job/TEST-OSX-ARM64/7/

What is the effect on users?

"this app is from unidentified developer" won't appear for new builds starting from November 1, 2023

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

@kambala-decapitator kambala-decapitator added this to the Omega 21.0 Beta 2 milestone Oct 31, 2023
@kambala-decapitator kambala-decapitator marked this pull request as draft October 31, 2023 13:38
@kambala-decapitator kambala-decapitator added No Jenkins do not run automatic Jenkins builds on this PR WIP PR that is still being worked on and removed No Jenkins do not run automatic Jenkins builds on this PR labels Oct 31, 2023
@kambala-decapitator kambala-decapitator added No Jenkins do not run automatic Jenkins builds on this PR and removed WIP PR that is still being worked on labels Oct 31, 2023
@kambala-decapitator kambala-decapitator removed the No Jenkins do not run automatic Jenkins builds on this PR label Nov 1, 2023
@kambala-decapitator kambala-decapitator marked this pull request as ready for review November 1, 2023 13:10
@kambala-decapitator
Copy link
Contributor Author

once approved, I'll adjust Jenkins jobs and merge right after that

@kambala-decapitator kambala-decapitator changed the title [macOS] migrate from altool to notarytool [macOS][Jenkins] migrate from altool to notarytool Nov 1, 2023
@lrusak
Copy link
Contributor

lrusak commented Nov 1, 2023

What Jenkins changes are needed?

@kambala-decapitator
Copy link
Contributor Author

What Jenkins changes are needed?

The script that configures Keychain and adds notarization credentials to it, iirc right before configure-xbmc. You can check the new version in the linked job.

@kambala-decapitator kambala-decapitator merged commit 68ee275 into xbmc:master Nov 14, 2023
2 checks passed
@kambala-decapitator kambala-decapitator deleted the macos-notarytool branch November 14, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport: Done Platform: macOS Type: Fix non-breaking change which fixes an issue v21 Omega
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants