-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS][Jenkins] migrate from altool to notarytool #24032
Merged
kambala-decapitator
merged 3 commits into
xbmc:master
from
kambala-decapitator:macos-notarytool
Nov 14, 2023
Merged
[macOS][Jenkins] migrate from altool to notarytool #24032
kambala-decapitator
merged 3 commits into
xbmc:master
from
kambala-decapitator:macos-notarytool
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kambala-decapitator
added
Type: Fix
non-breaking change which fixes an issue
Backport: Needed
Platform: macOS
v21 Omega
labels
Oct 31, 2023
kambala-decapitator
added
No Jenkins
do not run automatic Jenkins builds on this PR
WIP
PR that is still being worked on
and removed
No Jenkins
do not run automatic Jenkins builds on this PR
labels
Oct 31, 2023
kambala-decapitator
force-pushed
the
macos-notarytool
branch
from
October 31, 2023 18:42
ecbd31e
to
4aac29e
Compare
kambala-decapitator
added
No Jenkins
do not run automatic Jenkins builds on this PR
and removed
WIP
PR that is still being worked on
labels
Oct 31, 2023
kambala-decapitator
force-pushed
the
macos-notarytool
branch
from
November 1, 2023 08:40
4aac29e
to
9238a6c
Compare
kambala-decapitator
force-pushed
the
macos-notarytool
branch
from
November 1, 2023 11:14
9238a6c
to
21467dc
Compare
kambala-decapitator
removed
the
No Jenkins
do not run automatic Jenkins builds on this PR
label
Nov 1, 2023
kambala-decapitator
force-pushed
the
macos-notarytool
branch
from
November 1, 2023 13:10
182e3ba
to
21467dc
Compare
once approved, I'll adjust Jenkins jobs and merge right after that |
kambala-decapitator
changed the title
[macOS] migrate from altool to notarytool
[macOS][Jenkins] migrate from altool to notarytool
Nov 1, 2023
What Jenkins changes are needed? |
The script that configures Keychain and adds notarization credentials to it, iirc right before configure-xbmc. You can check the new version in the linked job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now using
notarytool
instead of the deprecatedaltool
to notarize the built dmg. Authorization changed from user/password to ASC API key.Motivation and context
altool
can no longer be used for notarization starting 01.11.2023. Email from Apple:How has this been tested?
Created test job on Jenkins with the necessary changes, checked logs for notarization success and tested on Mac. Successful build: https://jenkins.kodi.tv/view/All/job/TEST-OSX-ARM64/7/
What is the effect on users?
"this app is from unidentified developer" won't appear for new builds starting from November 1, 2023
Types of change
Checklist: