Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Android: add colorMode config to .Main activity in AndroidManifest.xml #24711

Merged
merged 1 commit into from
Feb 15, 2024
Merged

[Backport] Android: add colorMode config to .Main activity in AndroidManifest.xml #24711

merged 1 commit into from
Feb 15, 2024

Conversation

matthuisman
Copy link
Contributor

@matthuisman matthuisman commented Feb 14, 2024

backport of #24710

colorMode was added to .Splash but missing in .Main causing Kodi to be closed when color mode was switched or due to some TV + AVR setups.

Description

Motivation and context

How has this been tested?

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • Bug fix (non-breaking change which fixes an issue)
  • Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • Improvement (non-breaking change which improves existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that will cause existing functionality to change)
  • Cosmetic change (non-breaking change that doesn't touch code)
  • Student submission (PR was done for educational purposes and will be treated as such)
  • None of the above (please explain below)

Checklist:

  • My code follows the Code Guidelines of this project
  • My change requires a change to the documentation, either Doxygen or wiki
  • I have updated the documentation accordingly
  • I have read the Contributing document
  • I have added tests to cover my change
  • All new and existing tests passed

colorMode was added to .Splash but missing in .Main causing Kodi to be closed when color mode was switched or due to some TV + AVR setups.
@fritsch
Copy link
Member

fritsch commented Feb 15, 2024

@fuzzard would be good for the 20.0.4.1 - fixes a crash.

@fuzzard fuzzard added this to the Nexus 20.5 milestone Feb 15, 2024
@fuzzard fuzzard merged commit 6c004a9 into xbmc:Nexus Feb 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: Android Type: Backport Type: Fix non-breaking change which fixes an issue v20 Nexus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants