[backport] Allow to build with taglib-2.0 #24772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: - taglib/taglib@ca8c2e0 long/ulong updated to offset_t/size_t in taglib/toolkit/tiostream.h Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com> (cherry picked from commit d2022ce)
ref: - taglib/taglib@10094f6 Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com> (cherry picked from commit 6f5dff4)
final release of taglib-2.0 removed deprecated unused types from taglib. ref: - taglib/taglib@a08acdc - These integer types are deprecated. Do not use them. Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com> (cherry picked from commit e43460c)
final release of taglib-2.0 removed deprecated unused types from taglib. ref: - taglib/taglib@a08acdc - These integer types are deprecated. Do not use them. Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com> (cherry picked from commit 700bd7d)
|
Jenkins build this please |
1 similar comment
|
Jenkins build this please |
|
I've made some formatting changes to meet the current code style. The diffs are available in the following links:
For more information please see our current code style guidelines. |
|
Just as an FYI, but I thought we only backported fixes, which this isn't. Nexus could easily be built with Hope this doesn't set a precedent..... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #24339 and #24577
Motivation and context
Allow to build Kodi Nexus on systems that already switched to taglib-2.0, e.g. Arch Linux. This is primarily for my own convenience 😉
How has this been tested?
Compiles and scanning music library items works.
What is the effect on users?
None.
Types of change
Checklist: