Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: [depends]: boost: actually enable spinlock for shared_ptr multithread on arm #4062

Merged
merged 1 commit into from
Jan 22, 2014
Merged

FIX: [depends]: boost: actually enable spinlock for shared_ptr multithread on arm #4062

merged 1 commit into from
Jan 22, 2014

Conversation

koying
Copy link
Contributor

@koying koying commented Jan 21, 2014

AFAICT, the fallback was no protection at all

/cc @davilla

@koying koying mentioned this pull request Jan 21, 2014
Closed
@koying
Copy link
Contributor Author

koying commented Jan 21, 2014

jenkins build this please

@davilla
Copy link
Contributor

davilla commented Jan 21, 2014

nice find :)

@koying
Copy link
Contributor Author

koying commented Jan 21, 2014

Thanks ;)
Note that I'm not sure what will happen with android x86 builds (see boost/smart_ptr/detail/sp_counted_base.hpp)
I assume it will go thru boost/smart_ptr/detail/sp_counted_base_gcc_x86.hpp, but...

koying added a commit that referenced this pull request Jan 22, 2014
@koying
Merge pull request #4062 from koying/fixdependsboost
4ea0a7f 
FIX: [depends]: boost: actually enable spinlock for shared_ptr multithread on arm
@koying koying merged commit 4ea0a7f into xbmc:master Jan 22, 2014
@koying koying deleted the fixdependsboost branch January 22, 2014 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Gotham13.0-alpha12 January 2014
Development

Successfully merging this pull request may close these issues.
2 participants
@koying @davilla