upnp: several additions and improvements #4764
Conversation
| const NPT_String* url = nodes[i]->GetText(); | ||
| const NPT_String* type = nodes[i]->GetAttribute("type"); | ||
| if (type) artwork.type = type->SubString(0, 1024); | ||
| if (url) artwork.url = url->SubString(0, 1024); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks alright at a glance. some things aught to go upstream though. also rather sad that it's not possible to extend attributes without hacking so deep in platinum. |
|
@elupus: Thanks for taking a look. Yeah I really don't like it that we have to hack into so multiple Platinum source files just to get some additional properties supported. Furthermore there are quite a few properties there (like dc:publisher) which are either not properly implemented (like no support for multiple entries of the same type) or not implemented at all (i.e. no DIDL serialization/deserialization). I'll try to submit some of the patches (dc:publisher, SearchSync, GetSearchCapabilities and GetSortCapabilities) upstream. |
|
jenkins build this please |
|
@elupus: I've looked at the code and these limits on strings are everywhere. I've skimmed the UPnP specification and couldn't find anything about string length limitations. I'd prefer to keep the added code in line with the existing code though as it is more likely that it will be accepted upstream that way. |
|
A limit of 1024 for url can easily be exeeded by nested urls (rars in zips and so on). Please just assign them instead. The limit only make sense if it was stored in a fixed size array. Even if the code does like this already, we should not add to the practice. |
|
@elupus: Good point. I'll remove the limits. |
…om ContentDirectory v4
…es and artwork xbmc:dateadded to pass dateadded with items and not need to stat upnp resources for that xbmc:rating for number-based rating xbmc:votes for string-based votes number xbmc:artwork for a type-url-based mapping of artwork
…xbmc:rating, xbmc:dateadded and xbmc:votes
|
@elupus: Removed the string size limitations from the newly introduced code. jenkins build this please |
|
jenkins build this please (he's stubborn again on building. perhaps because starting it just after a force push) |
|
I'm alright with this. But do try to get it upstream + ask how they want us to handle extensions |
upnp: several additions and improvements
These are most of the additions to UPnP and the Platinum SDK from my media import work.