[pvr] adjust labels and refactoring for setting 'pvrplayback.startlast' #4969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change the current used labels 'Yes' and 'Minimised' to 'Foreground' and 'Background', so it's easier to understand what's happen if you choose one of these options.
…last' This removes the filler method for setting 'pvrplayback.startlast' and add options directly to the settings.xml.
|
Looks good to me. |
|
@opdenkamp ping |
|
no opinions? so i think it's fine. |
|
jenkins build this please |
|
told you i was busy this week and that i wouldn't have time to look at it... |
| @@ -1238,14 +1238,15 @@ | |||
| <default>true</default> | |||
| <control type="toggle" /> | |||
| </setting> | |||
| <setting id="pvrplayback.startlast" type="integer" label="19189" help="36228"> | |||
| <setting id="pvrplayback.continuelast" type="integer" label="19189" help="36228"> | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
dropped the commit which change the setting name |
|
jenkins build this please |
|
@opdenkamp any objections? |
|
nope |
xhaggi
added a commit
that referenced
this pull request
Jul 8, 2014
…-startlast [pvr] adjust labels and refactoring for setting 'pvrplayback.startlast'
gannondroid
pushed a commit
to gannondroid/xbmc
that referenced
this pull request
Jul 24, 2014
…back-startlast [pvr] adjust labels and refactoring for setting 'pvrplayback.startlast'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adjust the current used labels Minimised and Yes for the setting Continue last channel on startup to Background and Foreground, so they will be more suitable in case a user choose one of this options.
Apart from the label changes, I also change the current implementation for the setting. I removed the filler method and add the option directly to the settings.xml, which saves some lines in PVRManager.