[confluence] texture updates.

[un1versal]

I decided to retry re-submitting these improvements for two reasons,
_1)_ Much has evolved since original PR and since you cannot easily make a theme installer for default skin as it resides in system paths and not userdata that also requires some coding beyond my skills

_2)_ Since _1)_ is more time consuming and unlikely to happen as easily. Confluence can alternatively by default ship with a _second theme_ if so, This could easily be re-submitted as a secondary theme to be included by default. That probably require a different PR though.

Testing

https://github.com/uNiversaI/revamped.themes/archive/2.3.5.zip by following instructions and selecting Revamp-osf theme (note the background used in theme not included in this PR)

dropped 6cd3169
The only addition new graphics currently unused is commit 6cd3169 [confluence] Add NEW Default HDD icons … which probably requires xml or maybe sourcecode changes which are atm beyond my ability. That adds 3 new types DefaultBDFull/Empty.png and DefaultUSB textures. which I thought would be nice to include. But will require assistance from a skinner to make them usable.

I tried to separate each change into separate commits to maybe make this reviewing simpler (if that's at all possible)

I will be happy try to accommodate any requests improvements

@ronie or whoever is responsible for deciding, please decide, if not wanted just close the PR.

Note all current psd sources can be found at https://github.com/uNiversaI/revamp-confluence-psds

[ronie]

my only concern is the blue color used for the new icons, it does not match the rest of the skin imo.
see before/after comparison below:

not only the folder icon suffers from this, but the scrollbar and close icon as well.

also, please drop un1versal@6cd3169
we're not gonna add unused stuff to the skin (requires core changes first).

[un1versal]

I plan on changing the folders too As in new folders) so they can match, but I suppose for time being the hdd color can change that shade to match what currently there.

For the unused stuff, I will drop it then for now, but was hoping that these would be supported at some stage. Hence I asked for help in that they are after all common. Can we work together on that?

[un1versal]

Updated a few more. @ronie and addressed the comments you shouldn't notice any differences now.

All folders icons redone which makes the blue hdd icon and the folders match closer now, also updated the glyphs a little.
The scrollbar/progress also should be ok

####Testing
https://github.com/uNiversaI/revamped.themes/releases/tag/2.3.5 by following instructions and selecting Revamp-osf theme

I also dropped the unused icons though the idea was to show here they exist to be implemented when core changes support them. @topfs2 would it be possible to add a second theme by default?

[un1versal]

@ronie un1versal@e2a45d6 matches #5684 new icons

📣 Test with right click _save as_ here to download test compressed textures

📣 click https://github.com/uNiversaI/revamped.themes/releases/tag/2.3.5 and follow instructions to change theme and color

[ronie]

@da-anda @BigNoid @Black09 thoughts?

[da-anda]

will need to test first, but ideally we'd match Confluence to the colour of the new logo which most likely also will be blueish. But given the rush we're in this most likely won't be an option.

[da-anda]

ok, just gave it a try and also reviewed some of the commits to get an impression of the actual changes. In general I like the new icons and artwork, but I don't like that new blue. It has too much saturation IMO.

edit: noticed that with this texturepack applied we're having 3 shades of blue now, and the flat OSD close button as well as the flat scroll/seek bar somehow don't fit to the rest of the skin (like the hover status of buttons)

[topfs2]

I'd say focus on the new logo and we can do a match of color to it or it to
something for I*
On 20 Nov 2014 15:12, "da-anda" notifications@github.com wrote:

ok, just gave it a try and also reviewed some of the commits to get an
impression of the actual changes. In general I like the new icons and
artwork, but I don't like that new blue. It has too much saturation IMO.

—
Reply to this email directly or view it on GitHub
#5350 (comment).

[un1versal]

👍 This is why I suggested that this is a secondary theme available by default (everyone gest something now). its acceptable imo to each platform, _you cant download themes for system skin atm via some theme installer that way more coding wise that I cant do._
What I do is continue improving things to try try to match shades more closely, its a great deal of work, I hate to see wasted, or just for personal use. _But in time for Helix or I... its too much to ask. I been working on this for long time now on and off._

You can improve things greatly now, with this and what I have going. Thats more love than confluence ever saw for all these years. Perfect? No! is anything?

@da-anda 👎 As is default skin is _now currently there's 4 or 5 shades of blue_. So less matching imo than this by any account.

_On the theme itself I changed the color.xml blue to match so really there's only 2 or 3 shades not 4 0r 5. I intend to improve this further as I have time to fix things_. If you download the theme 2.2.7 you will see what I mean. The xbt is only a quick test platform fyi.

On the folders and hdd blue its possible to make it less saturated but again currently is less matching.

The general idea is to improve pixelation (try in a 40"+ screen with default and you see) +update the graphics, Most importantly each time someone does adds some new graphic more oddness being introduced (the osd looks fantastic with this) anywhere you look is fresh. And its all full editable vectors on psd.

/me shrugs Im taking the hard job nobody wants. Im happy with the direction and will continue on irrespective 😄

[ronie]

edit: noticed that with this texturepack applied we're having 3 shades of blue now

thx for taking the time to test this PR and for your feedback too.
my main concern are the different shades of blue this PR introduces as well.

@UniversaI adding this as a second theme is not an option i'm afraid.
either we're going to replace the current textures with yours, or nothings going to change at all.

[un1versal]

Ok, I'm confused with these shades of blue comments. Default skin as is has more variations of the blue shades, way way way more.

ideally the test would be during a longer usage period, 5 minutes is a maybe too sudden change?

Ill try to add screenshots, though screenshots with limited range on, not black black like it looks on my TV screen.

I will push the color.xml changes too also then which improves the shades of blue thing.
But you guy have to test with the theme https://github.com/uNiversaI/revamped.themes/releases/tag/2.2.7
And not test with juts xbt clearly that was a mistake to offer it standalone.

Ok Im clear on that second theme not going to happen.

[Memphiz]

you have a different background in that screenshot right? Cause is still have bubbles (but revamped) when using your revamp theme ...

[ronie]

Ok, I'm confused with these shades of blue comments.

well, let me try to explain.

as an example, here are some of the original images:

they are all (more or less) the same shade of light blue.

now compare that to your images:

you left two of them untouched (still light blue) and the other two are now in a darker shade of blue.

also, you decided to make the close button flat. but on the other hand, you leave the glossy/3d effect on the other textures.

in short, the original images are somewhat unified in colour and used effects.
but yours are a mixture of some originals and some of your designs, which are quite different in colour.

i think if you decide to change 1 image, you're gonna have to change all of them and not stop half way.

[un1versal]

Thanks I see, that is indeed clear on what you mean.

Ultimately I intend to complete the full set and remake the remainder of textures, but for now I think I can try to put the gloss back on close button then.

Let me see what I can come up with and will ping you again. I want this to go as best as possible. Old age Im not as fast as I use to be. 😸

Do you think aside from this and assuming close button is ok, Is the remainder is a blocker given the other benefits? Or must this be 100% finished before you consider merging or can I continue working on them as and when if this is merged?

[Memphiz]

My 2 cents - i rellay like the fact of a change - it gives a sort of new ambiente and would be a nice addition to the new logo for helix imo.

[zag2me]

Yep consistent colours are a must for any theme. I like the work you have done, but have to agree its too strong a blue on the icons.

Nice work though, its appreciated.

[un1versal]

@Montellese added un1versal@bb727f7 for your commit d96e69c now available on https://github.com/uNiversaI/revamped.themes/archive/2.3.5.zip for testing/usage.

[MartijnKaijser]

our GUI guys think the blue is to saturated so this will never get merged.

[un1versal]

thx for closing this. I knew it was a massive waste of my time.

I was working on a less saturated one but now with this closed I wont resubmit again..

[MartijnKaijser]

you were told many times the blue is too saturated.

[un1versal]

@da-anda @ronie @topfs2 @Memphiz

I addressed all comments about color saturation and before I was given a chance to update this PR, someone closed it. (a feel out of frustration related to some other PR kinda evil IMO sadly.)

To test download https://github.com/uNiversaI/revamped.themes/archive/3.1.5.zip

Apply _Revamped-osf_ theme

Still todo: new Wallpaper

⚠️ This PR, Would need be updated and reopened if desired. _Its too much work to separate all the images by groups like this does_ and Im not going to bother just so someone has the pleasure of closing it to slap me across the face.

Else, the work is there anyone can go and grab it as it is GPL

Comments welcome.

[Memphiz]

@UniversaI i like that one too (revamped-osf it is)

[un1versal]

Thank you, Pending a minor tweak or other (which I'm doing ATM) its not saturated at all, so lets see what gives from the others. Just need to do a wallpaper but tbh I'm not a creative type, so am a bit stuck on that.

[un1versal]

@Memphiz @ronie @da-anda @phil65 @BigNoid

I already spend many hours addressing all saturation issues and am very happy with results in https://github.com/uNiversaI/revamped.themes/archive/4.0.1.zip and revamped-osf that should satisfy the requirements and comments above mentioned.

I'm really looking for feedback on whether this PR can be re-opened and ill update it then with those changes because its a huge deal of work for PR alone, Im not willing to waste time if no one really wants these changes anyway.

one last try for before the breech as isengard beta1 nears.

[da-anda]

@UniversaI just tried your theme. The colors of the OSD icons and folders look good to me now (the DefaultXXX icons/thumbs), but I still feel some colors don't match well yet. For example the button hover texture and the one used for focused file items in lists. They might have the same blue colour, but the visual impression is different. So when the color is used on a larger area it probably could be dimmed a bit.
I also noticed that the list item hover texture doesn't fade out nicely on the edges - so one is able to see a edge in the area that's supposed to be 100% transparent already.

And please don't get me wrong - I appreciate that the blue has less saturation, but it's now a little to desaturated because you also chaged the color of the blue itself (not in majority of the images, but the text in the home menu f.e.). But keep it like that for now.

What I really don't like is the background, but that can be changed independently.

@ronie what do you think?

[un1versal]

@da-anda thank you, could you provide a couple of screenshots indicating the problems you mentioned? That would help greatly (my old tired eyes) may need the visual queue to notice some things.

The background is something I threw together in 5 minutes, It could be greatly better (im not very creative), tbh anything to me looks better than that old one now.

[phil65]

Now that we have SamFisher on board I definitely want him to design our new UI textures (or at least all the DefaultIcon stuff). The stuff he did for AudioDSP is just too amazing to leave him out for any skin rework.

[da-anda]

@phil65 your suggestion is something for a new skin IMO

@UniversaI will prepare a screenshot

[un1versal]

@da-anda

I think I know what you meant by the some of the comments above

I also noticed that the list item hover texture doesn't fade out nicely on the edges - so one is able to see a edge in the area that's supposed to be 100% transparent already.

that above fixed

I dimmed down the submenu focus textures a bit wasnt sure what other textures need dimming

Until I see your screenshot cant really address things Im not sure which ones you mean or what exactly.

see https://github.com/uNiversaI/revamped.themes/archive/4.02.zip

Idle like to get this ready for isengard beta if you guys want it at all.