Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PVR] Search window fixes #8144

Merged
merged 2 commits into from
Sep 29, 2015
Merged

[PVR] Search window fixes #8144

merged 2 commits into from
Sep 29, 2015

Conversation

ksooo
Copy link
Member

@ksooo ksooo commented Sep 27, 2015

  • Fix "Find similar program" for timers to prefer EPG tag title over timer title. Although containing often the EPG title of the broadcasting, a timer title can be completely unrelated to the broadcast as it is freely editable by the user.
  • Fixed OnPrepareFileItems only to search if requested to do so and not just a simple window refresh is ongoing. Before, every CGUIWindow::Refresh triggered a search. For example, selecting "Find similar" in timer's context menu resulted in two calls to OnPrepareFileItems. First call did a search with previous search data (if present), second call did a search with the current data. Two dialogs popped up, first "Searchig ... " then "Searching ... " ... All weird.

@xhaggi mind taking a look.

@ksooo ksooo added Type: Fix non-breaking change which fixes an issue Component: PVR labels Sep 27, 2015
MartijnKaijser
MartijnKaijser reviewed Sep 27, 2015
View reviewed changes
xbmc/pvr/windows/GUIWindowPVRSearch.cpp
CGUIDialogOK::ShowAndGetInput(CVariant{194}, CVariant{284});
m_bSearchConfirmed = false;
}
CGUIDialogOK::ShowAndGetInput(CVariant{194} /* "Searching..." */, CVariant{284} /* "No results found" */);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@ksooo
[PVR] Search window: Fixed OnPrepareFileItems only to search if reque…
b8d1957 
…sted to do so and not just a simple window refresh is ongoing.
@ksooo
Copy link
Member Author

ksooo commented Sep 27, 2015

@MartijnKaijser better now? ;-)

@ksooo ksooo added this to the Jarvis 16.0-alpha3 milestone Sep 27, 2015
@ksooo
Copy link
Member Author

ksooo commented Sep 29, 2015

@xhaggi good to go?

@xhaggi
Copy link
Member

xhaggi commented Sep 29, 2015

yep

@ksooo
Copy link
Member Author

ksooo commented Sep 29, 2015

jenkins build this please

ksooo added a commit that referenced this pull request Sep 29, 2015
@ksooo
Merge pull request #8144 from ksooo/fix-find-similar-for-timers
9a8f353 
[PVR] Search window fixes
@ksooo ksooo merged commit 9a8f353 into xbmc:master Sep 29, 2015
@ksooo ksooo deleted the fix-find-similar-for-timers branch September 29, 2015 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Component: PVR Type: Fix non-breaking change which fixes an issue
Projects
None yet
Milestone
Jarvis 16.0-alpha3
Development

Successfully merging this pull request may close these issues.
3 participants
@ksooo @xhaggi @MartijnKaijser