Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getTransactionData(XChainClient, BinanceChain, Cosmos, ThorChain) #63

Merged
merged 6 commits into from
Nov 4, 2020
Merged

getTransactionData(XChainClient, BinanceChain, Cosmos, ThorChain) #63

merged 6 commits into from
Nov 4, 2020

Conversation

icafa
Copy link
Contributor

@icafa icafa commented Nov 2, 2020 •
edited by veado
Loading

  • add getTransactionData in XChainClient
  • add getTransactionData in XChainBinance
  • add getTransactionData in XChainCosmos
  • add getTransactionData in XChainThorchain

Part of #60
Fix #66

@icafa icafa requested a review from veado November 2, 2020 14:37
@icafa icafa changed the title getTransactionData(XChainClient, BinanceChain) getTransactionData(XChainClient, BinanceChain, Cosmos, ThorChain) Nov 3, 2020
thatStrangeGuyThorchain
thatStrangeGuyThorchain reviewed Nov 4, 2020
View reviewed changes
packages/xchain-binance/src/client.ts Outdated Show resolved Hide resolved
packages/xchain-binance/src/client.ts Outdated Show resolved Hide resolved
packages/xchain-cosmos/src/client.ts Outdated Show resolved Hide resolved
packages/xchain-thorchain/src/client.ts Outdated Show resolved Hide resolved
veado
veado approved these changes Nov 4, 2020
View reviewed changes
Copy link
Collaborator

@veado veado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junkai121 Well done + great job!

@veado veado mentioned this pull request Nov 4, 2020
Closed
6 tasks
@icafa icafa merged commit edd4d7c into master Nov 4, 2020
@veado veado deleted the issue-60 branch November 4, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatStrangeGuyThorchain thatStrangeGuyThorchain thatStrangeGuyThorchain left review comments

@veado veado veado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix start time for xchain-binance Client.prototype.getTransactions
3 participants
@icafa @veado @thatStrangeGuyThorchain