Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with -c switch #65

Closed
ema opened this issue Oct 19, 2016 · 1 comment
Closed

Issues with -c switch #65

ema opened this issue Oct 19, 2016 · 1 comment
Assignees
@xcir

Comments

@ema
Copy link
Contributor

ema commented Oct 19, 2016

Hi,
there seems to be a bug in the way the -c switch is honored:
https://github.com/xcir/python-varnishapi/blob/master/src/varnishapi.py#L891

When passing -c, in case of VSL_t_req transactions the conditional on line 891 is False (because vsl[0].c_opt is True). However, the final conditional on line 895 is True, and the transaction gets ignored.
@xcir xcir self-assigned this Oct 24, 2016
@xcir xcir closed this as completed in d8b259a Oct 26, 2016
@xcir
Copy link
Owner

xcir commented Oct 26, 2016

Thank you for your report.
This code is unnecessary and had bug.
In Varnish had match processing(/lib/libvarnishapi/vcl.c)

Thanks!

wmfgerrit pushed a commit to wikimedia/operations-puppet that referenced this issue Oct 28, 2016
@ema
varnishapi.py: import latest upstream version
f987ecc 
Update varnishapi.py to the latest version (d8b259a), which fixes a bug
affecting the -c switch.

Change-Id: I408738550f585c102c2a645c1c6e52ffc76d426c
Ref: xcir/python-varnishapi#65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcir xcir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xcir @ema